-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add schema dirs to dist dirs #272
Conversation
Starting to review this now. |
"build": "webpack --progress", | ||
"watch": "webpack --progress -w", | ||
"build": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress", | ||
"watch": "rm -rf dist && mkdir dist && cp -R schemas dist/ && webpack --progress -w", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this actually need to be in the watch step? It only really matters for creating the zip file that's deployed, and that relies on the build step (if I'm correct).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually try to keep the behavior of build
and watch
really similar. In this case including it as part of watch
will be useful for working on tasks when they are npm link
ed into deployments, which is something I've needed to do before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary: This makes sure the schemas directory is placed in the dist directory for tasks that use the cumulus-message-adapter.
Addresses CUMULUS-414: Schema validation not being performed on many tasks
Changes
Example error
Here's an example of an exception thrown in discover-granules because of a failing schema validation:
This ^ is the expected behavior that was missing that this PR addresses. It'll make it easier to debug collection/rule configuration problems.
Test Plan
Things that should succeed before merging.
./bin/eslint-ratchet
and verify that eslint errors have not increased